search

madskristensen / MarkdownEditor

A Visual Studio extension
Other
409 stars 92 forks source link

Bold / Italics not working as described #68

Open Enigma644 opened 7 years ago

Enigma644 commented 7 years ago

Installed product versions

Ctrl +B isn't working and Ctrl +I is doing * for itallics when the project description states:

Keyboard shortcuts Ctrl+B makes the selected text bold by wrapping it with **. Ctrl+I makes the selected text italic by wrapping it with _.

GitHub markdown syntax has single chars for italics and double chars for bold as per: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet

Also, ideally hitting the shortcut a second time should unwrap the * or _ chars to return the text to normal.

Steps to recreate

Select text, hit Ctrl +B, or Ctrl + I.

Current behavior

Ctrl + B does nothing Ctrl + I does do itallics, but with the * character instead of _ as stated in docs.

Expected behavior

Ctrl + B should wrap and unwrap text with double * or __ Ctrl + I should wrap and unwrap text with single \ or _

jeffklawiter commented 7 years ago

I second this. It is not working for me either. I went to see if I could manually wire it up in the keyboard options but couldn't find any commands related to markdown. After some further digging I see it's registered under "Format.Bold" and is registered with Ctrl+B.

xoofx commented 7 years ago

I tried to debug this, and this is working from the debugger... but, the VS experimental hive doesn't have many extensions... particularly, ReSharper that is often conflicting... and when I try MarkdownEditor installed on the regular VS, the bold commands is not working. So just to confirm, do you have ReSharper installed? If no, what are the other extensions that you have?

Enigma644 commented 7 years ago

Almost all of these were installed by default, but for the purpose of clarity, here is the complete list of everything that shows under Tools> Extensions and Updates > Installed > All:

xoofx commented 7 years ago

@Enigma644 so no ReSharper? (ReSharper doesn't show up in the Extensions and Updates)

Enigma644 commented 7 years ago

I don't recall installing it. Where would it be, so I can double check?

xoofx commented 7 years ago

You have at least a top level menu "ReSharper"

Enigma644 commented 7 years ago

No

madskristensen commented 7 years ago

Can you verify this is fixed in the latest version, please?

Enigma644 commented 7 years ago

Tested with v1.11.201 Ctrl+I wraps with * and wraps again with further Ctrl+I's rather than unwrapping. Ctrl+B prompts on the status bar "(Ctrl+B) was pressed. Waiting for second key of chord..." I have default keyboard mapping under Tools -> Options -> Environment -> Keyboard for "Visual C# 2005" so I've not put anything custom in.

HopefulDavid commented 8 months ago

Hello there @madskristensen, I also have a issue with insert markdown italics for VS 2022. This looks like a small issue with unexpected behavior. I don't see most of the keyboard shortcuts mentions under "Markdown" actions and in global actions.