madskristensen / RainbowBraces

A Visual Studio extension
Apache License 2.0
132 stars 7 forks source link

Select colors that resemble resistor code colors 1-9 #44

Closed SkyGen closed 1 year ago

SkyGen commented 1 year ago
BrunoBlanes commented 1 year ago

You can change the default color for each level in Visual Studio settings, you don't need a PR for this, however, as an electrical engineering student, I am intrigued to know how those colors turned out. Could you post a simple picture here as is in the readme.md file?

SkyGen commented 1 year ago

I used Goldenrod for Level 4 to show better in light theme but still good on dark. I toyed with using Khaki, which also works well, but Goldenrod shows better on light mode (IMHO)!

Dark Mode: image

Light Mode: image

madskristensen commented 1 year ago

This is awesome. Thank you!! Since you've added an additional .sln file, the GitHub Actions workflow don't know how to build anymore. Could you possibly update the worklfow file to point directly to the RainbowBraces.sln file?

SkyGen commented 1 year ago

Thanks, Mads! Trying to figure out how to update the workflow file since this is the first time I've submitted a PR here! Also had one more change.

madskristensen commented 1 year ago

Do we need the new .sln file and projects you added? How about just removing them?

SkyGen commented 1 year ago

I updated the workflow file as follows. Not sure what the current dir is during the build, do I need to specify $(SolutionDir)RainbowBraces.sln ?

- name: Build
  run: msbuild RainbowBraces.sln /v:m -restore /p:OutDir=\_built
SkyGen commented 1 year ago

Sorry, I made the last change before seeing your last response! Sure, I can change the workflow file back and remove the test project, NP! Standby for the update...

SkyGen commented 1 year ago

Removed test project - give her a try now, thanks!

madskristensen commented 1 year ago

Awesome. Thank you!!

SkyGen commented 1 year ago

Hey, thanks, Mads, for creating RainbowBraces! It's very cool and helps with every day work!