madskristensen / SolutionColors

A Visual Studio extension
Apache License 2.0
77 stars 11 forks source link

Make it configurable on a per-user basis #2

Closed gamosoft closed 2 years ago

gamosoft commented 2 years ago

Hello there, thanks for this simple but useful extension. :-)

My suggestion would be to make this configurable on a per user basis, instead of saving the color in the actual .sln file, which is shared across all team members, and some may not like others' chosen colors. ;-)

Thank you very much. Kind regards.

madskristensen commented 2 years ago

It's not a bad idea but let me explain why I wrote the color into the .sln file. One of the scenarios where colors are helpful is when you work with multiple branches of the same repo. If you don't store the color information in the repo, then it gets lost. Now that I think about it, perhaps that is ok and you can just assign a color again when you need to. What do you think?

gamosoft commented 2 years ago

i (personally) wouldn't mind having to manually reassign a color

better yet, the extension could read from both places: by default from the .sln file and then from a .suo file (for example, or settings or whatever)

this way, the one in the user file would take precedence over the default in the sln file (depending on which ones are present). if found in suo, use that, otherwise if found in sln use that, else nothing of course :-)

in any case thanks again for this extension. :-)

gamosoft commented 2 years ago

Thanks for this, now it's much more flexible, and in fact the .vs folder looks like a perfect place. ;-) Just a minor annoyance, once you set up the color you cannot change it as the option is grayed out:

image

and if you manually delete the .vs folder then even if you assign the color back it doesn't work anymore (I can't see the line).

madskristensen commented 2 years ago

Oh, that's a bug that it is grayed out

gamosoft commented 2 years ago

thanks a lot, it all works now like a charm!

kind regards.