search

madskristensen / Tweakster

A Visual Studio extension
Apache License 2.0
240 stars 23 forks source link

Shortcut for Reopen Document work (CTRL+SHIFT+T) is already used by Go To Files #37

Closed yannduran closed 3 years ago

yannduran commented 3 years ago

For me the current key chord CTRL+SHIFT+T, CTRL+SHIFT+T for the Reopen Document command doesn't work because as soon as the first CTRL+SHIFT+T is pressed, the Go To dialog opens set to Go To Files:

image

CTRL+T, CTRL+T is available as is CTRL+R, CTRL+D which is actually more intuitive for Reopen Document.

I'm happy to create a pull request that changes the shortcut to either of the suggested chords (or something else) if you also find that the current shortcut doesn't work, if you'd like me to go ahead and do that.

bilalmehrban commented 3 years ago

I was just going to open the same issue. what I think is that there should be an option to modify the shortcuts of this extension.

yannduran commented 3 years ago

@bilalmehrban unfortunately extensions can't provide their own option for a user-selectable shortcut, but Visual Studio provides the UI to do so manually.

Click on Tools | Options | Environment | Keyboard, search for File.ReOpenClosedFile, remove the CTRL+SHIFT+T shortcut currently added by the extension, and assign whatever shortcut you prefer.

Actually I don't know why CTRL+SHIFT+Z (Edit.UndoClose) doesn't seem to reopen a document/tab that's been closed. So I wonder why there's both Edit.UndoClose and File.ReopenDocument and what the difference between them is supposed to be.

@madskristensen do you know?

An already built-in way is CTRL+1, R (or CTRL+1, CTRL+R ) and then select the file you want to reopen. You can select the file you want using the keyboard (using Up or Down arrow) and pressing ENTER, or clicking on a file in the list.

Also ALT+F, F (or ALT+F, ALT+F - just don't let go of the ALT key in between) is a quick way to jump to recent files list in the File menu.

So maybe this Tweaks command isn't even necessary? Or I guess it's a faster way of reopening the last closed document, as the built-in ways require selecting from a list.

bilalmehrban commented 3 years ago

Thank you for the clarification 😊🤞