search

madskristensen / TypeScriptDefinitionGenerator

A Visual Studio extension
Other
85 stars 46 forks source link

Dts package did not load correctly #55

Closed Daniel-Prescience closed 2 years ago

Daniel-Prescience commented 3 years ago

Installed product versions

Description

Extension works fine in VS2019, but I get the following error when trying to configure options for dts in VS2022: Dts-Error

Attached VS2022 activity log with an error description at the end of the file: Dts-Error-VS2022-ActivityLog.log

Steps to recreate

Go to "Generate d.ts" in VS options menu. It's possible that the issue could be caused by having VS2022-preview installed alongside VS2019?

Current behavior

Extension doesn't work.

Expected behavior

Extension should work.

BobSilent commented 3 years ago

Same for me, it says in LOG:

LegacySitePackage failed for package [DtsPackage]
Source: 'mscorlib' 
Description: Could not load file or assembly 'Microsoft.VisualStudio.TextTemplating.VSHost.15.0, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
ericop commented 2 years ago

same on VS2022 Pro (non-preview) for me. I uninstalled this extension and the modal popping up with that error each time I started my solution went away.

StarNamer commented 2 years ago

I also get his with VS2022 Pro Current. The extension was installed as part of the Dev Essentials package, but since we don't currently use TypeScript I'm quite happy to just uninstall this extension which sorts the error.

valeriob commented 2 years ago

Hi, i confirm it's not working on vs 2022 :(

EDIT : i was able to make it work on Visual Studio 2022 with this changes : https://github.com/madskristensen/TypeScriptDefinitionGenerator/pull/57

GeorgeLeithead commented 2 years ago

Same problem for me, using Visual Studio 2022 Community Edition (64-bit), version 17.0.4. I disabled this extension and re-loaded visual studio, and there was no error.

BrianMinister commented 2 years ago

Still having this problem on VS 2022 Ent Edition. 17.0.6

itniels commented 2 years ago

I have been seeing this issue as well also on the latest 17.1.0. Is there a solution for it in the near future @madskristensen?

realsircodesalot commented 2 years ago

I too am seeing this error in VS2022. A DDG search brought me here essentially.

Regarding PR #57:

Could we create a new .csproj specifically for VS2022, have it reference the same files but point to the VS2022 SDK & editor requirements and it's own source.extension.vsixmanifest. Should separate vsix packages be generated or is there a way to include the projects together in a single vsix package somehow?

TBH: I consider myself a VS extension noob as I have only dabbled with VS extension development. In addition I haven't really looked into how other projects may have resolved a similar issue or what recommendation(s) would be. (I know my lack of experience is showing lol).

valeriob commented 2 years ago

I wish i was able to do more, i'm not familiar with the process to package a new extension unfortunatly, i would really prefer @madskristensen to do it.

realsircodesalot commented 2 years ago

@valeriob, Thanks for a taking a shot at this issue! tbh, I wouldn't mind chipping in myself.

@madskristensen, when you get a moment, if you have any specific direction/recommendations, I'm sure we'll figure out a way resolve this issue while maintaining backward compatibility. My "gut feeling" is that maintaining backward compatibility is key.