search

madskristensen / WebAnalyzer

A Visual Studio extension
Other
55 stars 17 forks source link

Linters silently fail if there are comments in configs #10

Open pgatilov opened 8 years ago

pgatilov commented 8 years ago

Adding any kind of comment (line or block) to a linter config causes it to silently stop working.

Known to reproduce on:

Steps to reproduce (csslint example):

  1. Make sure you have a warning or error. For example, add a CSS rule with !important
  2. Add a line or block comment to .csslintrc
  3. Run Web Analyzer

Actual result: all CSS warnings and errors disappear from Error List

Expected result: there should be an error saying that linter is not working at all.

pgatilov commented 8 years ago

I am not sure, but I assume linters somehow report an error in this case that could be shown to the user in VS Error List.

I'll try to fix it

liamhughes commented 8 years ago

I have had other situations where ESLint has failed silently. Never tracked down the cause as I had no errors to work with.

madskristensen commented 8 years ago

Yeah, right now the extension just swallows the errors

dee-see commented 8 years ago

I had a typo in my config and had the same problem (silent failure). A debug mode would be great.