madskristensen / WebAnalyzer

A Visual Studio extension
Other
55 stars 17 forks source link

TSLint linter update #46

Open IlBaffo opened 7 years ago

IlBaffo commented 7 years ago

Hi, a couple of days ago TS 2.0 is gone public and there is some new syntax that is not recognized by the current version of the linter. For example "readonly" keyword and "null" type keyword are not supported.

As the TSLint project is already updated to support those keywords (since they went in beta release I think), is there a way to update the linter version without recompiling the extension? The installed version seems to be 3.3.0 and the most recent is 3.15.1.

For the moment I worked around the "null" keyword by defining a Nullable type but for the readonly keyword there is no solution...

Than you.

maboivin commented 7 years ago

+1. It would be nice if you could configure the extension to use a different version of tslint.

Over time, you don't necessarily need a new version of the extension but you may want to update the version of tslint you are using. For example, it would be nice if you could specify tslint@4.0.0 and the extension would automatically get the right version for you. It could be the same for all the linters. I understand it may break the extension if tslint changes the way they report their errors but at least you can rollback a change if you upgrade to an incompatible version.

HolgerJeromin commented 7 years ago

@rich-newman (https://github.com/rich-newman/typescript-analyzer) or @vladeck (https://github.com/vladeck/TSLint) both did a VS2017 version of a tslinter. Perhaps one can provide a VS2015 extension to fix this bug?

vladimir-djokic commented 7 years ago

@HolgerJeromin actually, its other way around: @rich-newman did typescript-analyzer extension and myself TSLint.

Now, unlike Web Analyzer and Typescript Analyzer, TSLint extension does not "force" the user to use packaged version of TSLint, but rather whatever is suited for the project (but locally installed using npm). In theory, this can support TSLint from the first to the last version.

If there is demand for Visual Studio 2015 version of extension I developed, please let me know and I'll take look at implementing one.

HolgerJeromin commented 7 years ago

@vladeck swapped the links. Sorry :-)

Using an installed tslint is a good thing, so we have to maintain one tslint version less :) I would love to have a 2015 version. This would result in less build aborts on my build server because i can check locally more easily. :-)

vladimir-djokic commented 7 years ago

@HolgerJeromin No problem :)

As for Visual Studio 2015 version of the extension, I'll take a look at implementing one.

vladimir-djokic commented 7 years ago

@HolgerJeromin You can download Visual Studio 2015 version of the extension here. See if it works and please report any issues on GitHub here.