WebManifest.IsValid implementation is wrong - Githubissues

madskristensen / WebEssentials.AspNetCore.ServiceWorker

Other

339 stars 61 forks source link

WebManifest.IsValid implementation is wrong #90

Open bugproof opened 2 years ago

bugproof commented 2 years ago

https://github.com/madskristensen/WebEssentials.AspNetCore.ServiceWorker/blob/f67af550637d61226584806e0ba14e31357114e2/src/Webmanifest/WebManifest.cs#L89

short_name and start_url are not required https://developer.mozilla.org/en-US/docs/Web/Manifest

also I don't understand the requirement for 512x512 and 192x192 icon sizes...