madskristensen / WebEssentials2015

A Visual Studio extension for web developers
Other
300 stars 92 forks source link

SVG previewing crashes Visual Studio #135

Open 06b opened 8 years ago

06b commented 8 years ago

Installed Web Essentials 2015.1 (Version 1.0.198) Running Visual Studio Professional 2015 - Version 14.0.24720.00 Update 1.

When attempting open an svg, visual studio will hang and at some point crash.

Let me know what other details you need from me. Keep up the good work :+1:

jarvklo commented 8 years ago

I get the same problem in the same version of VS (Visual Studio Professional 2015 - Version 14.0.24720.00 Update 1) Web essentials 1.0.204 Windows 10 (if I select an SVG file in the solution explorer and clicks in the source pane, the Editor hangs, then VS crashes, sometimes VS is reloading/restarting automatically. Sometimes it completely crashes)

I get the same problem when working with .html files containing elements in the editor as well.

Contact me for further details if needed.

madskristensen commented 8 years ago

I cannot repro this issue. Do you have any other extensions installed that may cause this? ReSharper for instance? If so, what happens when you disable those extensions?

jarvklo commented 8 years ago

Resharper is there. Haven't tried to do the "disabling tango" - yet ;) Here's the error entry in the VS activity log and one of the files that causes the crash:

`

6489
<time>2016/02/05 11:23:34.581</time>
<type>Error</type>
<source>Editor or Editor Extension</source>
<description>System.ArgumentNullException: Value cannot be null.&#x000D;&#x000A;Parameter name: key&#x000D;&#x000A;   at System.Collections.Generic.Dictionary2.FindEntry(TKey key)&#x000D;&#x000A;   at Microsoft.VisualStudio.Html.Package.Extensions.ExtensionsManager.OnTextViewCreated(ITextView textView, ITextBuffer textBuffer)&#x000D;&#x000A;   at Microsoft.Web.Editor.Controller.TextViewConnectionListener.OnTextViewGotAggregateFocus(ITextView textView, ITextBuffer textBuffer)&#x000D;&#x000A;   at Microsoft.VisualStudio.Html.Package.Commands.Html.VsHtmlTextViewConnectionListener.OnTextViewGotAggregateFocus(ITextView textView, ITextBuffer textBuffer)&#x000D;&#x000A;   at Microsoft.Web.Editor.Controller.TextViewConnectionListener.&lt;&gt;c__DisplayClass24_0.&lt;OnTextViewConnected&gt;b__0(Object sender, EventArgs eventArgs)&#x000D;&#x000A;   at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.RaiseEvent(Object sender, EventHandler eventHandlers)</description>

`

[cause.zip](https://github.com/madskristensen/WebEssentials2015/files/119049/cause.z

Is there another log somewhere that might help?

06b commented 8 years ago

I forgot that I had Resharper installed and active when I created this issue. I've currently have Resharper disabled and previewing SVG works fine with it disabled for me.

jarvklo commented 8 years ago

Yep - Resharper seems to be the prime suspect allright!

I went the other way around uninstalled Web Essentials to prevent the crashes since I've needed Resharper more than Web Essentials for a while... ... and the problem went away so I didn't think more of it other than that I've missed Web Essentials...

... and now an identical crash has appeared for another filetype... So - it feels highly unlikely this is caused by Web Essentials!

Thanks for pointing me in the right direction on this Mads! ... and sorry 'bout the confusion.

h5yr

/Åke J