search

madskristensen / WebPackTaskRunner

A Visual Studio extension
Other
39 stars 16 forks source link

Several instances of webpack #11

Closed sochix closed 8 years ago

sochix commented 8 years ago

Hi! I bind webpack -watch to solution open event. Every time I'm open a solution i get a new instance of webpack watch. Can it be only one instance?

madskristensen commented 8 years ago

I'm not sure I understand. When binding to project open, a process is kicked off running webpack watch. When you close the solution or VS then that process is terminated. Is that not what you experience?

sochix commented 8 years ago

Nope. When you update your project from version control system visual Studio triggers open project event and I get two running instances of webpack. The same will happen if you click unload on project and load it again. 15 янв. 2016 г. 19:42 пользователь "Mads Kristensen" < notifications@github.com> написал:

I'm not sure I understand. When binding to project open, a process is kicked off running webpack watch. When you close the solution or VS then that process is terminated. Is that not what you experience?

— Reply to this email directly or view it on GitHub https://github.com/madskristensen/WebPackTaskRunner/issues/11#issuecomment-172011165 .

scottaddie commented 8 years ago

@sochix I am definitely able to reproduce this myself. I opened the project, which already had the "Watch - Development" task bound to Project Open. I then unloaded the project and then reloaded it from Solution Explorer. At that point, I had 2 "Watch - Development (running)" tabs in TRX.

@madskristensen I would expect the aforementioned "Watch - Development" task to terminate when the project is unloaded. That would solve the problem of 2 running instances. Thoughts? I have logged issue https://github.com/aspnet/Tooling/issues/373 for this, as it appears to be a core TRX bug.

madskristensen commented 8 years ago

Correct, this is a bug in TRX. Thanks for opening the bug. I'll close it here since it has to be fixed by VS