search

madskristensen / WebPackTaskRunner

A Visual Studio extension
Other
39 stars 16 forks source link

Bindings isn't working correctly #9

Closed sochix closed 8 years ago

sochix commented 8 years ago

Hi! Thank you very much for your work, it's really awesome to have such integration between VS and Webpack.

My issue: I found, that everytime i create binding the task name doesn't change. /// <binding BeforeBuild='Development' ProjectOpened='Development' />

I select two different tasks:

I'm not quite sure, but I think it's wrong behaviour.

scottaddie commented 8 years ago

@sochix @madskristensen I ran into this same problem today. I'm working on a PR to fix this, but I'd like some feedback before I go too far with it. What if the task names were made unique? This is the easiest solution I can think of. See the screenshot below depicting the proposed changes in action:

webpack_bug

Thoughts on this proposed solution?

madskristensen commented 8 years ago

A rename of the tasks are needed. For instance Run - development

scottaddie commented 8 years ago

@madskristensen Agreed. Is that the naming convention (parent + task name) that you'd prefer? In other words, under the Run node in TRX, you'd see "Run - Development" and "Run - Production".

madskristensen commented 8 years ago

I think so

sochix commented 8 years ago

I think it's a good and quick solution. 29 дек. 2015 г. 3:23 пользователь "Scott Addie" notifications@github.com написал:

@sochix https://github.com/sochix @madskristensen https://github.com/madskristensen I ran into this same problem today. I'm working on a PR to fix this, but I'd like some feedback before I go too far with it. What if the task names were made unique? This is the easiest solution I can think of. See the screenshot below depicting the proposed changes in action:

[image: webpack_bug] https://cloud.githubusercontent.com/assets/10702007/12027696/f9aa6946-ad8f-11e5-8022-63ec998e3eab.png

Thoughts on this proposed solution?

— Reply to this email directly or view it on GitHub https://github.com/madskristensen/WebPackTaskRunner/issues/9#issuecomment-167683056 .

scottaddie commented 8 years ago

@sochix Now that this change is merged in, you can try it out by clicking the "nightly build" link here: https://github.com/madskristensen/WebPackTaskRunner/blob/master/README.md.

scottaddie commented 8 years ago

@madskristensen This issue can be closed, now that this fix has made its way to the stable version.