search

madskristensen / WinterIsComing

Apache License 2.0
11 stars 2 forks source link

Menu's background color is still coming from Dark Mode. #2

Open TanvirArjel opened 3 years ago

TanvirArjel commented 3 years ago

All the menu's background color is still coming from Dark Mode. Please give it a shade of Winter IS Comming's main theme color.

options

gracegtaylor commented 3 years ago

Hi @TanvirArjel thank you for sharing this feedback! The VS version uses a dark background color for dropdowns, which matches the Dark Blue mode in the VS Code version. We worked with the original creator of the theme to come up with the VS version. While this dark background is intentional design, we will take your feedback into consideration as we move forward into iterating the conversions! Thanks for sharing.

Here's an example of menu UI in VS Code: dropdownwinteriscoming

TanvirArjel commented 3 years ago

@gracegtaylor If this even exists in the original VS Code theme, then the original theme's design is faulty. However, it should be fixed in the VS 2020 theme by applying a shade of the theme's main color.

gracegtaylor commented 3 years ago

@TanvirArjel Thanks for the feedback. We can understand that theming is really personal and everyone has different tastes. We can take your feedback into consideration and discuss with the authors. Since this issue pertains to the original Winter is Coming theme design, this issue isn't a bug. Thanks again for your input!

TanvirArjel commented 3 years ago

I liked this theme but due to this apparent color mismatch which looks weird, I had to switch to another theme.