search

madsmtm / objc2

Bindings to Apple's frameworks in Rust
https://docs.rs/objc2/
MIT License
280 stars 35 forks source link

clippy: Enable `semicolon_if_nothing_returned` #612

Closed waywardmonkeys closed 1 week ago

waywardmonkeys commented 2 weeks ago

One part of this required a change other than semicolons to fix type inferencing in crates/objc2/src/__macro_helpers/declared_ivars.rs.

waywardmonkeys commented 1 week ago

Sorry, I was away for the weekend on a trip. I understand a reasoning (not sure if it is "the reasoning") for having the semicolons in those unsafe blocks (since they're like any other block...)

I could edit this PR to not enable the lint and not include the unsafe blocks. This would still be an improvement, I think, since there's a bunch of missing semicolons that don't involve unsafe blocks.

madsmtm commented 1 week ago

I could edit this PR to not enable the lint and not include the unsafe blocks. This would still be an improvement, I think, since there's a bunch of missing semicolons that don't involve unsafe blocks.

That'd be nice, please do so!

waywardmonkeys commented 1 week ago

@madsmtm Updated. See what you think!