madsoulswe / Our.Umbraco.Honeypot

MIT License
1 stars 3 forks source link

Special font in Umbraco Forms field name #18

Open bjarnef opened 9 months ago

bjarnef commented 9 months ago

I wonder if there's a specific reason for the special font 𝖍𝖔𝖓𝖊𝖞𝖕𝖔𝖙 in Umbraco Forms field name?

https://github.com/madsoulswe/Our.Umbraco.Honeypot/blob/ec0149fe87cdb6d4535ac4367945e6419bfa0165/src/Our.Umbraco.Honeypot/HoneypotFieldType.cs#L21

In my opinion it looks a bit odd in combination with the other field types:

image

image

image

bjarnef commented 9 months ago

Besides that is the field supposed to be a interger and not just string? https://github.com/madsoulswe/Our.Umbraco.Honeypot/blob/ec0149fe87cdb6d4535ac4367945e6419bfa0165/src/Our.Umbraco.Honeypot/HoneypotFieldType.cs#L24

madsoulswe commented 6 months ago

Hi!

Sadly, the ugly text is intentional; the default Umbraco rendering outputs the name as a CSS class. I tried using different Unicode characters, but not all were visible in the backoffice. I'm not sure if this issue is AngularJS-specific or related to the browser. I would gladly replace it!

The 'Int' datatype was a test/experiment from the first version. All honeypot fields are text values, and this did log exceptions if something managed to bypass the validation and tried to store a string as an integer in forms.

bjarnef commented 6 months ago

Is it an issue if Umbraco render the "Honeypot" name as CSS class? Instead of "𝖍𝖔𝖓𝖊𝖞𝖕𝖔𝖙" ... perhaps the CSS class collide with something else it the class is honeypot, which any prefix and or suffix.

Then main request for this change, it because checks in razor on field name also need to check for "𝖍𝖔𝖓𝖊𝖞𝖕𝖔𝖙" and not "Honeypot" 😬😅