luposlip
commented
8 years ago UPDATE:
Just for your info: I've tried to replace my component fns for generating the Table and the TableRow's with code from @DaveWM's https://github.com/DaveWM/reagent-material-ui. And it immediately works:
(defn thing-row [thing-data click-handler is-selected]
(let [thing (:thing thing-data)
thing-id (:thing/id thing)]
[TableRow {:selectable true
:selected (is-selected)
:hoverable true
:on-click click-handler}
[TableRowColumn small-cell-styles (:distance thing-data)]
[TableRowColumn (:thing/name thing)]
[TableRowColumn thing-id]]))
(defn things []
(let [the-things (subscribe [:things])
the-thing (subscribe [:thing])]
(fn []
(let [nearby (:some-things @the-things)
others (:other-things @the-things)
all-things (into nearby others)]
[Table
[TableHeader {:displaySelectAll false
:adjustForCheckbox false}
[TableRow
[TableHeaderColumn small-cell-styles "Distance"]
[TableHeaderColumn "Name"]
[TableHeaderColumn "ID"]]]
[TableBody {:displayRowCheckbox true
:deselectOnClickaway false
:showRowHover true}
(for [thing-data all-things]
^{:key (thing-data-id thing-data)}
[thing-row thing-data
#(do (dispatch [:thing thing-data])
(dispatch [:push {:event-data [:location/update (:location thing-data)]}]))
#(= (thing-data-id @the-thing) (thing-data-id thing-data))])]]))))And yes, I have tried to move the :key meta data from the inner to the outer component fn also when using your library! ;)
Best, Henrik
madvas
Hi there!
Generally
cljs-react-material-ui 0.2.19seems pretty solid from my point of view, using it withreagent 0.6.0-rc.I have a situation where I create a
Table(based on data from are-framesubscription). When I have all the code for creating therui/tablein the same component fn it works without an issue.But when I split the component into a component fn calculating the output for the
tableand an inner component fn for each row a couple of odd things happen:onRowSelectiondefined for therui/tabledoesn't trigger. I fixed this by using anon-clickhandler for eachrui/table-rowinsteadmaterial-ui.inc.js:777 Uncaught Invariant Violation: Objects are not valid as a React childMy components are as follows:
The complete stack trace is:
Am i doing something wrong?
Best, Henrik