search

madvas / cljs-react-material-ui

Clojurescript library for using material-ui.com
Eclipse Public License 1.0
205 stars 32 forks source link

Fixing the "usage" example as it's wrong #38

Open etiago opened 7 years ago

etiago commented 7 years ago

The usage example has a mistake and makes it so that when people do copy/paste, they end up with a wrong example.

cjohansen commented 7 years ago

You need both namespaces - get-mui-theme resides in cljs-react-material-ui.core

madvas commented 7 years ago

This is not really correct. Usage with reagent is lower. To improve readability we can probably rename first "Usage" to "Usage with Om" and make "Using with Reagent" header bigger

cjohansen commented 7 years ago

Wow, I completely overlooked that as well :( Suggestion: a table of contents on the top, to bring people's attention to the fact that there are multiple guides for setup.