madvas / cljs-react-material-ui

Clojurescript library for using material-ui.com
Eclipse Public License 1.0
205 stars 32 forks source link

Update to a more recent pre v1 material-ui version. #46

Open Michieljoris opened 6 years ago

Michieljoris commented 6 years ago

Getting errors such as:

react-dom.inc.js:526 Warning: Expected onMouseUp listener to be a function, instead got false.

If you used to conditionally omit it with onMouseUp={condition && value}, pass onMouseUp={condition ? value : undefined} instead. in input (created by EnhancedSwitch) in div (created by EnhancedSwitch) in EnhancedSwitch (created by Toggle) in Toggle (created by components.groups.page/Form) in div (created by components.groups.page/Form) in div (created by components.groups.page/Form) in div (created by components.groups.page/Form)

with latest react versions. Which seems to be fixed in later material-ui versions such as 0.19.4

miikka commented 6 years ago

As a workaround, you can directly depend on a newer version of cljsjs/material-ui. I've been using these dependencies for a while and it seems to work fine:

[cljs-react-material-ui "0.2.50" :exclusions [cljsjs/material-ui]]
[cljsjs/material-ui "0.19.4-0"]
binarykitchen commented 5 years ago

@miikka nope that workaround didnt help. seeing errors like Cannot read property 'CSSTransitionGroup' of undefined