search

madwill / feathers-horizon

Feathers horizon plugins
MIT License
3 stars 0 forks source link

An in-range update of ws is breaking the build 🚨 #8

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.1.0 of ws just got published.

Branch Build failing 🚨
Dependency ws
Current Version 3.0.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

ws is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/madwill/feathers-horizon/builds/258022945?utm_source=github_status&utm_medium=notification)
Release Notes 3.1.0

Features

  • Added ability to specify the handshake request timeout (#1177).

Bug fixes

  • Fixed an issue where CloseEvent.wasClean was incorrectly set to false for
    close codes in the 3000-4999 range (#1146).
Commits

The new version differs by 28 commits.

  • 4e3ada1 [dist] 3.1.0
  • b320169 [feature] Allow client to specify handshake request timeout (#1177)
  • 5c06c8f chore(package): update eslint to version 4.3.0 (#1176)
  • ab6c1c2 [minor] Remove redundant assignments
  • d781190 chore(package): update eslint to version 4.2.0 (#1169)
  • 16bbddb [doc] Fix "unware" and "reponse" typos in README.md (#1168)
  • 3544e30 chore(package): update eslint-plugin-import to version 2.7.0 (#1167)
  • afb36e9 [doc] Fix typos in API docs (#1165)
  • 833766f chore(package): update eslint-plugin-node to version 5.1.0 (#1155)
  • 034ab89 [ci] Test on node 8
  • c311c43 [lint] Fix lint issues
  • 0434428 chore(package): update eslint to version 4.1.0 (#1151)
  • 2d4dc08 chore(package): update eslint-plugin-import to version 2.6.0 (#1149)
  • cd55ced chore(package): update eslint-plugin-import to version 2.5.0 (#1147)
  • bb2e952 [fix] Set wasClean to true when close code is in 3000-4999 range (#1146)

There are 28 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.0.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.