search

madwort / improv-analysis

1 stars 0 forks source link

Waveform rending bug in safari - analysis rod1 #11

Open rconstanzo opened 8 years ago

rconstanzo commented 8 years ago

For some reason this analysis: http://rodrigoconstanzo.com/analyses/?q=rod1

Only renders the first 40seconds of the image in Safari 9.02, whereas Firefox 39 renders the whole thing correctly.

I've emptied cache, and tried it on multiple computers, and still nothing.

madwort commented 8 years ago

Verified - same issue on Safari 7.1.5 here ( works on FF ). Will investigate. Is this the longest track / largest mp3 file so far?

On 14 Dec 02015, at 10:35, Rodrigo Constanzo notifications@github.com wrote:

For some reason this analysis: http://rodrigoconstanzo.com/analyses/?q=rod1

Only renders the first 40seconds of the image, whereas Firefox renders the whole thing correctly.

I've emptied cache, and tried it on multiple computers, and still nothing.

— Reply to this email directly or view it on GitHub.

rconstanzo commented 8 years ago

Oddly, no. This one renders fine, and it's over twice as long: http://www.rodrigoconstanzo.com/analyses/?q=feldman

If this is a rough fix it's not high priority (as in before thesis stuff) as it only seems to effect this particular analysis.

I also tested to make sure the audio plays fine so it's not the mp3 that's corrupted or something. (I've also reuploaded the mp3 a couple times, though I haven't reencoded it).

rconstanzo commented 8 years ago

This one DOES have the most analysis points, but I don't think that would effect the waveform rendering.

madwort commented 8 years ago

Weird. You could try re-encoding it with slightly different mp3 parameters & see if you can bypass the bug (in case there's something weird in the mp3 that Safari's decoder is barfing on), or try a different format - I quite like .m4a but not sure if Firefox will decode it, .ogg is obviously good but Safari won't decode that... We're using the most recent version of the waveform lib (hasn't been updated since I last did work on this) https://github.com/bbcrd/waveform-data.js , this bug looks maybe similar-ish but not really (and is a browser bug... https://github.com/bbcrd/waveform-data.js/issues/32 )

rconstanzo commented 8 years ago

Ok, tested a bunch of different stuff.

Transcoded 128kb mp3 didn't work. Transcoded wav file WORKED! (but took forever to render it) Transcoded 320kb mp3 (from wav file) didn't work.

Versions that didn't work showed the same 46seconds only, which is weird. That's 7%, which doesn't appear to be a significant number, computationally.

rconstanzo commented 8 years ago

Also tested encoding an mp3 with iTunes instead of audacity and still nothing.

madwort commented 5 years ago

just checking the changelog for waveform-data.js, there is a bugfix for Safari https://github.com/bbc/waveform-data.js/blob/master/CHANGELOG.md#v210-20181110 , not sure whether this will fix the issue we're seeing. Unfortunately, we're on v1.5 and the bugfix is in v2.1, and there's a little bit of re-jigging to get from v1 to v2 of that lib...