madyankin / postcss-modules

PostCSS plugin to use CSS Modules everywhere
MIT License
1.6k stars 88 forks source link

Animation keyframe name is not always transformed to local scope name #83

Open ghost opened 6 years ago

ghost commented 6 years ago

Actual: The following input,

@keyframes slideIn {
  0% {
    margin-left: 100%;
  }
  100% {
    margin-left: 0%;
  }
}

.case-1 {
  animation: 2s slideIn;
}

.case-2 {
  animation: slideIn 2s;
}

when using the command, postcss input.css -u postcss-modules -o output.css

generates the following output

@keyframes _slideIn_1329k_1 {
  0% {
    margin-left: 100%;
  }
  100% {
    margin-left: 0%;
  }
}

._case-1_1329k_19 {
  animation: 2s :local(slideIn);
}

._case-2_1329k_27 {
  animation: _slideIn_1329k_1 2s;
}

Expected I would expect the keyframe name to be transformed in both cases.

madyankin commented 6 years ago

@ben-mckernan sorry, I haven't enough time now :(. If you'll be able to tackle this, PR is welcome!

SuperOleg39 commented 4 years ago

Have same bug, looks like problem inside post-css-modules-scope

madyankin commented 4 years ago

Subscribed to the linked PR, will update the deps when it's merged

mischnic commented 3 years ago

The linked PR is merged, any chance this package can be updated?

madyankin commented 3 years ago

@mischnic will be able to check on the weekend, thanks for pinging me