testFormatKeys makes assertions about supported keys found in the JSON output, but not about ones that aren't found. All assertions are of the form self.assertTrue(True), which cannot fail if a regression bug is later introduced.
https://github.com/madzak/python-json-logger/blob/v2.0.1/tests/tests.py#L87-L89
The test should make assertions that can fail to prevent future bugs.
testFormatKeys
makes assertions about supported keys found in the JSON output, but not about ones that aren't found. All assertions are of the formself.assertTrue(True)
, which cannot fail if a regression bug is later introduced. https://github.com/madzak/python-json-logger/blob/v2.0.1/tests/tests.py#L87-L89 The test should make assertions that can fail to prevent future bugs.