search

madzak / python-json-logger

Json Formatter for the standard python logger
BSD 2-Clause "Simplified" License
1.7k stars 231 forks source link

Enable Universal Wheels #113

Closed castrapel closed 2 years ago

castrapel commented 3 years ago

The purpose of this PR is to enable Universal Wheels in python-json-logger using the instructions outlined here: https://packaging.python.org/guides/distributing-packages-using-setuptools/#id74

Context: The existing python-tag=py34 makes the command pip wheel --no-binary python-json-logger --no-deps python-json-logger==2.0.1 use the py34-none-any.whl, but there's no such thing AFAIK.

It should also be possible to rm setup.cfg and everything will work fine, you could even publish a py3-none-any.whl file easily since this is a pure python package.

madzak commented 2 years ago

Thanks for the contribution, but the package no longer supports python2.7 so based on my understanding, universal wouldn't fit. It shouldn't be locked to the python 3.4 version (especially given EOL) so i changed it to py3 in this commit (https://github.com/madzak/python-json-logger/commit/b07b580670c6c4e340c372c73d0e76cdddc8b456).