search

madzak / python-json-logger

Json Formatter for the standard python logger
BSD 2-Clause "Simplified" License
1.7k stars 231 forks source link

Drop Python 3.5 support and pypy 3.6 support #131

Closed bringhurst closed 2 years ago

bringhurst commented 2 years ago

To allow for typing annotations and enforcement of typing annotations, we need to:

See https://github.com/madzak/python-json-logger/pull/129#issuecomment-1030708627 for additional background.

bringhurst commented 2 years ago

I'm not completely sure about this PR -- GH actions doesn't seem to be running for me.

Based on the docs over at https://github.com/actions/setup-python, it may need to be pypy-3.8 in the build.yaml instead.

I don't have much experience with pypy in general.

jenstroeger commented 2 years ago

I'm not completely sure about this PR -- GH actions doesn't seem to be running for me.

@madzak may have to approve the actions to run on this PR.

madzak commented 2 years ago

Updated build action, but it won't run just yet. I'll merge and correct.

madzak commented 2 years ago

Action Run: https://github.com/madzak/python-json-logger/actions/runs/1802840349