search

mae1884 / nipper_ny

A starter template to build lightning fast websites with Ghost & Gatsby
https://gatsby.ghost.org
MIT License
0 stars 0 forks source link

Control the tag/theme color via CMS #5

Open mae1884 opened 3 years ago

mae1884 commented 3 years ago

Tags should use the theme color as set in the CMS. Perhaps this color should not be set by the CMS in terms of best practice. Still, the tags should be in CAPS, using sans-serif font, and should appear within the article in the Gatsby build.

marcomiduri commented 3 years ago

@mae1884 Can you explain about this?

mae1884 commented 3 years ago

@marcomiduri similar to the last one: see the tags on the homepage image

The tags are not styled like on albanycountypost.com

image

Also, the author image/avatar is displaying oddly.
image

"Theme color" refers to this https://albanycountypost.com/ghost/#/settings?showBrandingModal=true

image

If this should rather be set in the code, just tell me.

marcomiduri commented 3 years ago

@mae1884 Do you only need tag text color to be set with this accent color? thanks for providing these screenshots. I will update the avatar style.

mae1884 commented 3 years ago

@mae1884 Do you only need tag text color to be set with this accent color? thanks for providing these screenshots. I will update the avatar style.

We have not decided on the details of what color, what font, etc. Just wondering if it is possible to control it via the Ghost CMS, no matter the color. If not, we will have to wait.

marcomiduri commented 3 years ago

@mae1884 Yes, we can apply all these settings(Branding) on our frontend. Please let me know all Ghost settings you want to implement on our frontend.

mae1884 commented 3 years ago

@mae1884 Yes, we can apply all these settings(Branding) on our frontend. Please let me know all Ghost settings you want to implement on our frontend.

I know you can apply the settings, but are you saying they can be set via the Ghost CMS? if we change the color 5 weeks from now, will it update properly in the Gatsby build? or do I have to tell you the specific color settings and you code it in?

marcomiduri commented 3 years ago

@mae1884 You can only set it on GhostCMS Settings and trigger rebuild. Then the new color will be set. I just finished this. Sorry, I forgot to push the updates to the new branch. Updates are pushed to the master branch and it's on live website now. Please check it. I also updated the avatar image issue. Thanks

mae1884 commented 3 years ago

@mae1884 You can only set it on GhostCMS Settings and trigger rebuild. Then the new color will be set. I just finished this. Sorry, I forgot to push the updates to the new branch. Updates are pushed to the master branch and it's on live website now. Please check it. I also updated the avatar image issue. Thanks

Yes that is what I was trying to do. Wow. I just changed the color and it rebuilt on nipperny.com. You're great. Thank you. Can you point me to where in the code you connect the CMS to the front-end like that?

marcomiduri commented 3 years ago

Great, thank you. We can get all GhostCMS settings data using allGhostSettings query.

https://github.com/mae1884/nipper_ny/blob/88cb438606e267ab291ad46575d04c37625dac2c/src/templates/index.js#L65-L69

mae1884 commented 3 years ago

Ah, so it's Ghost API -- GraphQL -- Gatsby, @marcomiduri do we need to be concerned with how many queries we run in terms of performance?

Related: when the site is "rebuilt" does it rebuild every piece of content? When we migrate content from our old site, we will migrate 20,000+ posts, each with photos. Is there any consideration we need to make for how to handle that? We are a news site.

Great, thank you. We can get all GhostCMS settings data using allGhostSettings query.

https://github.com/mae1884/nipper_ny/blob/88cb438606e267ab291ad46575d04c37625dac2c/src/templates/index.js#L65-L69

marcomiduri commented 3 years ago

@mae1884 Queries will be run when the website built so it doesn't affect actual web pages. As you mentioned, if there are a lot of blogs, it will take some time to build the whole site. Netlify doesn't build only the updated things.

mae1884 commented 3 years ago

@mae1884 Queries will be run when the website built so it doesn't affect actual web pages. As you mentioned, if there are a lot of blogs, it will take some time to build the whole site. Netlify doesn't build only the updated things.

@marcomiduri Could that be a problem if we have 20, 30, 40,000+ posts?

mae1884 commented 3 years ago

@mae1884 Queries will be run when the website built so it doesn't affect actual web pages. As you mentioned, if there are a lot of blogs, it will take some time to build the whole site. Netlify doesn't build only the updated things.

@marcomiduri Could that be a problem if we have 20, 30, 40,000+ posts?

We need to be able to publish to the live site relatively quickly. 15 minutes to build is ok. Longer is not ok.

marcomiduri commented 3 years ago

@mae1884 I don't think so. As our project does SSR, it takes some time to build the pages on the server-side. I can't promise how many minutes it will take... It depends on the packages, dependencies, and project size

mae1884 commented 3 years ago

@mae1884 I don't think so. As our project does SSR, it takes some time to build the pages on the server-side. I can't promise how many minutes it will take... It depends on the packages, dependencies, and project size

Are we able to do this

Netlify doesn't build only the updated things.

Can we do this? https://www.netlify.com/blog/2020/04/23/enable-gatsby-incremental-builds-on-netlify/?utm_source=blog&utm_medium=gatsby-perf-jl&utm_campaign=devex

marcomiduri commented 3 years ago

@mae1884 I have used this on Gatsby v3 mostly and it worked fine but there were some issues on v2. Our project is using v2 so I don't recommend this unless we use v3.

marcomiduri commented 3 years ago

@mae1884 If you agree to upgrade the package versions to the latest, I will do that and set incremental build for you.