search

maedoc / libtvb

TVB C library
6 stars 8 forks source link

Finish region mapping implementation #112

Open maedoc opened 8 years ago

maedoc commented 8 years ago

Region mapping implementation currently incomplete and requires tests.

maedoc commented 8 years ago

Link to the code please?

See src/sys_regmap.c for the currently incomplete implementation.

The defaults needs to be filled out (see definition of sd_sys) and look at other system definitions for examples.

Feel free to send a PR as soon as you have something and we can work together on it.

paramhanji commented 8 years ago

Um I kind of need something to get started with. What should "defaults" contain? sd_sys also makes little sense to me. I'm sorry but I'm new here and if this isn't something a beginner can work on, let me know right away :p.

Actually I think I can be a lot more useful if you could give me an overview of sddekit_api.h . The file sddekit.h is straightforward but I don't understand what's happening in sddekit_api.h. Thanks!

AbheekG commented 8 years ago

@catchchaos "defaults" will contain code for setting all the pointers (function pointers) to default values. As done for apply. The functions can be seen at sddekit_api.h, or the initial PR.

@maedoc Sent PR. More understanding of region mapping required to implement fully.

maedoc commented 8 years ago

@catchchaos @abheekg you both tackled an undocumented feature! I'll add some details about this sometime today.