search

maedoc / libtvb

TVB C library
6 stars 8 forks source link

amend fsanitize SANFLAG in makefile #146

Closed AbheekG closed 8 years ago

AbheekG commented 8 years ago

@maedoc I intentionally didn't add it -fsanitize=float-cast-overflow . It is not working in both of my systems as mentioned earlier. Please let me know if it can be solved my tweaking with my installed packages.

maedoc commented 8 years ago

You're right, it isn't present in GCC 4.9.2, at least. GCC 5.3 supports it, but I agree, let's drop it for now. The address sanitizer is the most worthwhile one as it is much faster than valgrind.

maedoc commented 8 years ago

@abheekg :+1:

(This was a small change so a PR from your master was OK, but generally, please PR from a topic branch)