search

maedoc / tvb-lems

TVB models with LEMS
1 stars 1 forks source link

Limits on state variables? #4

Open pgleeson opened 5 years ago

pgleeson commented 5 years ago

@maedoc I can see how this might mean that the state variable is limited to >=0 and <=pi (or should it be 2*pi?):

https://github.com/maedoc/tvb-lems/blob/a450bd87fb23f69368f562baf60f0ad25aa836ae/tvb_lems/source.py#L49

but should this automatically translate into:

https://github.com/maedoc/tvb-lems/blob/a450bd87fb23f69368f562baf60f0ad25aa836ae/tvb_lems/kuramoto.lems.xml#L21-L23

i.e. is it a default rule that if you pass one limit you reset to the other?

maedoc commented 5 years ago

Good catch, that should be 2 pi.

This is the only model where we have an explicit state reset. In other cases, it’s used to inform when the system has become unstable, so I don’t think those resets should be generated automatically. Perhaps this should be denoted differently in the source metadata.