search

maelstrom-research / madshapR

2 stars 0 forks source link

dataset_visualize can't run #44

Closed jlaforme closed 1 year ago

jlaforme commented 1 year ago

Le code d'erreur est le suivant pour tous les datasets que j'ai essayé:

Error in names(summary_2) <- col: ! 'names' attribute [1] must be the same length as the vector [0] Backtrace:

  1. madshapR::variable_visualize(...)
GuiFabre commented 1 year ago

Hi @jlaforme ! and thank you for your first issue :)

I tested and updated (in case of) the packages madshapR and fabR. I faced no problem on prod, staging and misc.

Maybe the code you use is out of date (unfortunately you arrived in the team when we had a major update of those 3)

DATE Package version
2023-10-17 fabR 2.0.0
2023-10-17 madshapR 1.0.2
2023-10-17 Rmonize 1.0.0

here is a chunk of code to test with iris

library(madshapR)
packageVersion('madshapR')

variable_visualize(iris, Species)
dataset_visualize(iris,bookdown_path = 'here')

Can you re-test again ?

SamEBT commented 1 year ago

Erreur toujours la sans mettre de group_by, et meme en testant avec un dataset avec ou sans data dictionary associated.

image

a-trottier commented 1 year ago

The version of the package and the scripts were already correct. It was not the issue.

Repeated in R misc and Canpath with updated packages, using 2 different datasets.

GuiFabre commented 1 year ago

@jlaforme & @SamEBT : this has been corrected, can you test if for me ? Thanks👍

SamEBT commented 1 year ago

Tested with and without data dictionary attached and working well in both cases👍