Add layer type or types for shared-library dependencies.

maelstrom-software / maelstrom

Maelstrom is a fast Rust, Go, and Python test runner that runs every test in its own container. Tests are either run locally or distributed to a clustered job runner.

https://maelstrom-software.com/

Apache License 2.0

558 stars 11 forks source link

Add layer type or types for shared-library dependencies. #266

Closed nfachan closed 1 month ago

nfachan commented 5 months ago

If we get this right, we could remove the include_shared_libraries field.

We should at least support:

The ability to add shared library dependencies for the test binary.
The ability to add an arbitrary binary and its shared library dependencies.

nfachan commented 5 months ago

Maybe obviate #232

bobbobbio commented 2 months ago

We talked about what more specific to do here yesterday. This is what it sounded like we were converging on to me for this issue (and this release)

Don't mess with the include_shared_libraries flag, leave that working how it is
Add a new layer type which is for the shared library closure of a binary. This doesn't include the binary itself, so you can have separate prefix options for the binary and its dependencies. The binary would have to be included in its own layer.