search

maeltm / node-google-id-token-verifier

Apache License 2.0
23 stars 2 forks source link

Broken due to pull request #1 #2

Closed cakenggt closed 8 years ago

cakenggt commented 8 years ago

Even though this passed all the tests, it does not work in production. This is due to the crypto library trying to decode a PEM key, and instead finding a different type of key. V3 of the oAuth2 doesn't have the PEM keys anymore.

I would suggest rolling back pull request #1, as I don't know enough about the crypto library to know how to verify the new keys in the pull request.

maeltm commented 8 years ago

I worked to get PEM format from modulus n and exponent e. I cannot do test in production now. so if possible, can you test code in https://github.com/maeltm/node-google-id-token-verifier/tree/fromDiscoveryDoc

maeltm commented 8 years ago

Fixed this issue 30036004407ed4a511c50851b06a210b1ed6d708