maennchen / ZipStream-PHP

:floppy_disk: PHP ZIP Streaming Library
https://maennchen.dev/ZipStream-PHP/
MIT License
1.76k stars 105 forks source link

[v2] Allow psr/http-message v2 #256

Closed PaolaRuby closed 1 year ago

maennchen commented 1 year ago

@PaolaRuby Oh wait sorry, you're targeting v2. We will only consider bugfixes for the v2 branch since a new major version is out.

PaolaRuby commented 1 year ago

Ok, but no functionality is being added either, and test was fixed

angeljqv commented 1 year ago

@maennchen there are many 3rd party packages still using V2

maennchen commented 1 year ago

I've added some documentation to make the situation clear: https://github.com/maennchen/ZipStream-PHP#version-support

maennchen commented 1 year ago

@angeljqv In that case PRs against those libraries to update to the newest version or appreciated.

We have a new version out and all the new things will be implemented in that version. I commit to keep the previous major version working (bugfixes / security fixes), but not to change things to extend the scope of that version.

angeljqv commented 1 year ago

PRs against those libraries to update to the newest version or appreciated

That would be the best, but unfortunately Option/Archive.php was deleted, and it is a breaking change on my case, also the constructor changes

maennchen commented 1 year ago

@angeljqv I'm not sure I understand. That is one of the reasons why there's a new major version. Your code, any 3rd party library and zipstream itself need to be aligned on the same major version.

If there's changes needed in your code you should be able to migrate yourself. If there's changes needed in a 3rd party library in between, open a pull request for that or ask the maintainer of that library.

The current zipstream library should have feature parity except a few minor details. Therefore an update should be possible.

If there's a problem updating to v3, I'll happily provide guidance / support to make sure that the update is successful.

angeljqv commented 1 year ago

Also i'm using PHP 8.0 😕😕

maennchen commented 1 year ago

@angeljqv PHP 8.0 is unfortunately also out of active support: https://www.php.net/supported-versions.php

I align this project with PHP core and would only consider PHP 8.0 for security fixes.