search

maennchen / crontab

Parse Cron Expressions, Compose Cron Expression Strings and Caluclate Execution Dates.
https://hex.pm/packages/crontab
MIT License
91 stars 32 forks source link

Fix warning caused by usage of deprecated `Application.get_env` #116

Closed LouisMT closed 1 year ago

LouisMT commented 1 year ago

It seems that this should already be fixed, but I think the function_exported? check doesn't work for macros. The minimum version is already Elixir 1.10, so it should be safe to remove the whole check.

maennchen commented 1 year ago

Thanks @LouisMT

Merging when CI passes.

coveralls commented 1 year ago

Coverage Status

Coverage: 96.636%. Remained the same when pulling ac6fd1dbfefb01a62f68c0fae733875002cbb593 on LouisMT:fix-get-env-warning into 708a6883faa67bf8b47efe24fc7318a84e4c324b on jshmrtn:main.

maennchen commented 1 year ago

Hm. It has unrelated CI issues. Force-merging.