maennchen / crontab

:alarm_clock: Parse Cron Expressions, Compose Cron Expression Strings and Caluclate Execution Dates.
https://hex.pm/packages/crontab
MIT License
92 stars 33 forks source link

Ecto 3.2 Warnings #62

Closed philipgiuliani closed 5 years ago

philipgiuliani commented 5 years ago

After updating to Ecto 3.2, I got the following warnings:

warning: function embed_as/1 required by behaviour Ecto.Type is not implemented (in module Crontab.CronExpression.Ecto.Type)
  lib/crontab/cron_expression/ecto_type.ex:2: Crontab.CronExpression.Ecto.Type (module)

warning: function equal?/2 required by behaviour Ecto.Type is not implemented (in module Crontab.CronExpression.Ecto.Type)
  lib/crontab/cron_expression/ecto_type.ex:2: Crontab.CronExpression.Ecto.Type (module)

See the last 2 lines of https://github.com/elixir-ecto/ecto/blob/master/CHANGELOG.md#enhancements

maennchen commented 5 years ago

Thanks for the report, would you be willing to send a PR?

maennchen commented 5 years ago

Released as 1.1.8