search

maester365 / maester

The core repository for the Maester module with helper cmdlets that will be called from the Pester tests.
https://maester.dev
MIT License
299 stars 73 forks source link

CIS Check First Push #440

Closed NZLostboy closed 3 weeks ago

NZLostboy commented 1 month ago

First cut for some of the CIS checks.

This is the CIS checks that can be automated (according to CIS, I realise some of them can be done other ways and I will get to that) down to check 1.3.6.

I realise as I am writing this that I have missed the docs/commands entries so I will go back and do those today and add them here.

In the mean time if I could get a review and feedback on whats currently pushed that would be great.

NZLostboy commented 4 weeks ago

Here are some comments for feedback. Looks like a good start. Thanks!

Thank you, I will spend some time in the next day or so sorting them all out and adding the other bits.

Snozzberries commented 3 weeks ago

This is looking good @NZLostboy, I think the MD file and then passing build tests and this would be good for review. Thank you!

NZLostboy commented 3 weeks ago

This is looking good @NZLostboy, I think the MD file and then passing build tests and this would be good for review. Thank you!

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

I will add that note and try to work out the build fails today and then it can go through review.

Snozzberries commented 3 weeks ago

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

No need to manually build the mdx those get generated by the pipelines when the PR gets merged.

NZLostboy commented 3 weeks ago

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

No need to manually build the mdx those get generated by the pipelines when the PR gets merged.

Oh awesome! alright I will work on getting the builds fixed

NZLostboy commented 3 weeks ago

Builds fixed, sorry for the number of builds. I didn't know how to perform the tests locally but now I do.