search

maester365 / maester

The core repository for the Maester module with helper cmdlets that will be called from the Pester tests.
https://maester.dev
MIT License
336 stars 80 forks source link

MS.AAD.8.2 will fail if allowInvitesFrom is set to none #453

Closed mattcave closed 1 month ago

mattcave commented 1 month ago

MS.AAD.8.2 explicitly checks the authorizationPolicy for the allowInvitesFrom value being set to "adminsAndGuestInviters" (and nothing else). If the value is set to "none", the test will fail. Do you agree that "none" should also be seen as compliant?

mattcave commented 1 month ago

Happy to submit a PR if you agree.

Snozzberries commented 1 month ago

@mattcave thanks for this suggestion and great note. I would agree. If you feel comfortable doing the PR, looks like adding or none to the test would be a great PR.

https://github.com/maester365/maester/blob/main/powershell/public/cisa/entra/Test-MtCisaGuestInvitation.ps1#L28

mattcave commented 1 month ago

Proposed fix here - https://github.com/maester365/maester/pull/454

merill commented 1 month ago

Cheers. @mattcave merged!