maester365 / maester

The core repository for the Maester module with helper cmdlets that will be called from the Pester tests.
https://maester.dev
MIT License
356 stars 87 forks source link

Update Test-MtEidscaPR05.ps1 #461

Closed m-hanisch closed 1 month ago

m-hanisch commented 2 months ago

The value not null test seems to be static/hardcoded. fixes #459 line 29

merill commented 2 months ago

I just realized these will get overwritten when EIDSCA generation happens see https://maester.dev/docs/contributing#updating-eidsca-tests-and-documentation

Tagging @Cloud-Architekt

merill commented 1 month ago

@Cloud-Architekt is this issue resolved in the last PR you submitted? If so, can I close this one? tx.

m-hanisch commented 1 month ago

@merill Using the Maester PreRelease version 0.3.21-preview Install-PSResource -Name Maester -Prerelease I can confirm that the test EIDSCA.PR05: Default Settings - Password Rule Settings - Smart Lockout - Lockout duration in seconds. passes as expected with a value greater than the recommended 60

Using publicly available Maester version 0.3 the test fails. See #459

So I will close the pull request?

merill commented 1 month ago

Tx for testing and confirming. Yes please close this PR.