search

maestrith / AHK-Studio

Created with AHK Studio
http://www.maestrith.com
365 stars 68 forks source link

Variable Browser: Fix Callstack ListView #158

Closed holycrepe closed 6 years ago

holycrepe commented 6 years ago

This implements the following fixes:

  1. Populate ListView
  2. Use Correct Filename for Callstack
  3. Jump to Code after Selecting a Frame from Callstack ListView
holycrepe commented 6 years ago

If you plan on merging these changes, I can rebase on the current master & fix merge conflicts

maestrith commented 6 years ago

I'm really bad at Github... I will do my best to see if I can find your edits and them :)

holycrepe commented 6 years ago

So it looks like you have some duplicate files due to case sensitivity:

  1. README.md and Readme.md
  2. lib\Commands.xml and lib\commands.xml

I'll submit another PR to fix that issue. Once that is merged and I rebase this PR, you should be able to merge this PR without any conflicts

maestrith commented 6 years ago

Thank you! Do you use Skype, Discord, or Hangouts? I am maestrith@gmail.com or maestrith on all of them. I'd love to chat if you want to.

holycrepe commented 6 years ago

Absolutely, I won't be able to reach out until Friday however as I have exams coming up on Thursday.

holycrepe commented 6 years ago

Please don't hesitate to give me a nudge if I fail to follow up!

maestrith commented 6 years ago

lol ok.

maestrith commented 6 years ago

so it was just the Display() function right?

holycrepe commented 6 years ago

I believe so... The changes affect the Subroutine that is called when the ListView is clicked.

holycrepe commented 6 years ago

FYI, When getting the filename for the current stackframe, I just cleaned up the filename instead of trying to validate it the same way you do elsewhere in the code. So there are some issues, ie nested library includes, as such:

#Include <LibrarySubfolder\Module>

I'll look into it further next week and open up new issues as needed

maestrith commented 6 years ago

thank you for taking the time to do that. I really look forward to chatting.