search

maestrodev / librarian-puppet

Since 0.9.11.6 this fork is no longer used
MIT License
16 stars 7 forks source link

Tons of fixes #1

Closed zifik closed 11 years ago

zifik commented 11 years ago

Summary

I needed to accomplish a few things:

  1. Incorporate all of the fixes found in "tons-of-fixes"
  2. Incorporate librarian version 0.0.26 to get its improvements for handling proxies
  3. Update forge.rb to use a proxy in a similar fashion found in vendor/librarian/lib/librarian/chef/source/site.rb.

    Remarks

I would prefer to see vendor/librarian become a git submodule. However, since my time on working with this project has been very short, I didn't want to make such a change just yet. The changes to forge.rb are what I really needed. Those should definitely be preserved.

carlossg commented 11 years ago

Hey Kris, seems that librarian was split from chef https://github.com/rodjek/librarian-puppet/pull/79#issuecomment-14673561 http://rubygems.org/gems/librarian

The sensitive thing to do would be to depend on that gem and remove the librarian code from here

carlossg commented 11 years ago

I have opened a pull request to get the changes into librarian https://github.com/applicationsonline/librarian/pull/142

carlossg commented 11 years ago

as of 9b7f43a7da we are now using the librarian gem

carlossg commented 11 years ago

I have implemented proxy for the forge (not yet for github tarballs) by using open-uri http://www.ruby-doc.org/stdlib-1.9.3/libdoc/open-uri/rdoc/OpenURI.html "The environment variables such as http_proxy, https_proxy and ftp_proxy are in effect by default."