search

maestrodev / puppet-android

A Puppet module to install the android SDK
22 stars 40 forks source link

Return an error on failed packages - not working again, apparently. #36

Open cintiadr opened 9 years ago

cintiadr commented 9 years ago

This is probably a regression from https://github.com/maestrodev/puppet-android/pull/24

This was fixed in da769379e476a052b509b1ff5523f8f44e01302f but I believe 2701669bbc9d614af7cd48136deb1551ce424feb caused the same problem.

I'm using version 1.2.0 from puppet forge, and I can the that the 'expect' file is the last one.

dbeckham commented 9 years ago

I can confirm this is happening as well. Using the older Android SDK version installed by this module, newer platforms like android-21, etc. aren't available. Instead of producing a failure during the Puppet run, Puppet happily reports that it executed the install on each run.

Using an bogus platform version, Puppet reports success:

Notice: Android::Platform[android-100]/Android::Package[android-100]/Exec[update-android-package-android-100]/returns: executed successfully

The SDK tool itself reports something along the lines of:

Error: Ignoring unknown package filter 'android-100'
Warning: The package filter removed all packages. There is nothing to install.
         Please consider trying to update again without a package filter.
jantman commented 8 years ago

I can confirm this is happening for me as well, for build-tools:

android::build_tools {'build-tools-23.0.2': } says that it executed successfully, but builds against that version don't work, and:

root@e2916e0cdcdf android]# ls /usr/local/android/android-sdk-linux/build-tools/
20.0.0  23.0.1

If I run the command in the expect file, I get the same error that @dbeckham mentioned above. It seems to me that these execs should have a creates attribute?