search

maestrodev / puppet-maven

A puppet recipe for Apache Maven, to download artifacts from a Maven repository, install Maven, configure settings.xml,...
http://www.maestrodev.com
Apache License 2.0
73 stars 77 forks source link

Bug fixes for settings.xml profiles support #58

Closed evansj closed 8 years ago

evansj commented 8 years ago

Sorry, some bugs crept in to my pull request that was applied yesterday.

  1. Adds null checks in the template. nil doesn’t respond to empty?
  2. the pluginRepositories section was accidentally a duplication of the repositories section because it accessed the wrong hash key
  3. the element was completely missing from repository
  4. Use better examples (different repositories / pluginRepositories) in settings_spec.rb to catch more errors

Also, the plugin_repositories hash key has been renamed to pluginRepositories to match the XML.