search

maestrogerardo / i3-gaps-deb

Tool to create and install Debian (or Ubuntu) packages of i3-gaps.
GNU General Public License v3.0
313 stars 45 forks source link

Added compatibility with parrotOS #20

Closed eversinc33 closed 4 years ago

eversinc33 commented 4 years ago

ParrotOS does not store the repos in sources.list but in sources.list.d/parrot.list so the script produces an error about missing repositories when running it on parrot. By extending the grep in igd_checkSourcesList() this is solved.

maestrogerardo commented 4 years ago

Hi eggdog,

I don't see any improvement applying your patch:

Imho "grep -r ... sources.list*" does consider "sources.list.d/parrot.list" as well. Do I miss sth.?

eversinc33 commented 4 years ago

Hey, I was expecting the same, but it did not, image I guess it has to do with the way grep handles wildcards.

maestrogerardo commented 4 years ago

Don't know what you are trying to do, but to me it seems that your command is completely broken as you are trying to grep "filenames" instead of their actual contents.

eversinc33 commented 4 years ago

Actually you are right, I forgot to put in the xargs before grep, to make the filenames piped into the command get used as arguments. My bad

maestrogerardo commented 4 years ago

... I suggest that you try this patch instead (which adds parrot detection support): parrot.tar.gz

If it works for you (and finally let you install i3-gaps on parrot w/o any other issues), I consider to include it into mainline.

eversinc33 commented 4 years ago

It worked with the above for me (even though the command was wrong) and I got i3 running. Thanks and sorry for the confusion!