search

maestrolab / SMAREACTcleaned

the cleaned up version of REACT as of 2023
GNU General Public License v3.0
1 stars 0 forks source link

Combine pre-processor with calibration GUI #7

Closed walgren closed 10 months ago

walgren commented 11 months ago

Add a table to the calibration GUI and add the relevant pre-processor so everything is in one place. This will involve changing the file organization, function references, and formatting. When this is done, see if we can add an option to skip the ASMADA file reading.

walgren commented 10 months ago

I'm skeptical that I have the time to do this... The pre-processor GUI is not in a format that would be easy to translate to a "tab" of the existing calibration GUI (i.e., there are 100+ references to "mainWindow," which changes context when it's a tab). This task may take 50+ hours of code refactoring...

Additionally, philosophically, the two GUIs (pre-processing and calibration) do fundamentally different things. I am not sure it makes sense to combine them. The required work to integrate them (i.e., create export functions and data objects to go from pre-processing to calibration) might not be worthwhile.

mingear commented 10 months ago

this is fine.