search

mafintosh / csv-parser

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else
MIT License
1.41k stars 134 forks source link

fixed function name #153

Closed 0xflotus closed 4 years ago

0xflotus commented 4 years ago

I only fixed a typo

codecov-io commented 4 years ago

Codecov Report

Merging #153 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          141      141           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 264e15a...548cd9b. Read the comment docs.

shellscape commented 4 years ago

Thanks for the PR. Unfortunately that's not a typo. We could've named that variable batman and it would've been valid.

0xflotus commented 4 years ago

Thanks for the PR. Unfortunately that's not a typo. We could've named that variable batman and it would've been valid.

But you use a wrong function name three lines later....

shellscape commented 4 years ago

And that's why we have a Pull Request template. You chose to remove that template. If you hadn't, you could have explained that and the change would have made sense.