search

mafintosh / csv-parser

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else
MIT License
1.41k stars 134 forks source link

refactor: prefer builtin Buffer utils over ponyfills #169

Closed TrySound closed 4 years ago

TrySound commented 4 years ago

This PR contains:

Breaking Changes?

If yes, please describe the breakage.

Please Describe Your Changes

I see builtin buffer utils were not used because of old node support. Though they are dropped now. And there is no need in these dependencies.

https://github.com/mafintosh/csv-parser/pull/83#issuecomment-377797828

Though I hope this change will not recover this problem.

https://github.com/mafintosh/csv-parser/issues/81

codecov-commenter commented 4 years ago

Codecov Report

Merging #169 into master will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   97.24%   97.20%   -0.04%     
==========================================
  Files           1        1              
  Lines         145      143       -2     
==========================================
- Hits          141      139       -2     
  Misses          4        4
Impacted Files Coverage Δ
index.js 97.20% <100.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57365bc...2912896. Read the comment docs.

shellscape commented 4 years ago

@TrySound conflicts

TrySound commented 4 years ago

Fixed