search

mafintosh / csv-parser

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else
MIT License
1.41k stars 134 forks source link

refactor: replace ndjson with custom serialize #170

Closed TrySound closed 4 years ago

TrySound commented 4 years ago

This PR contains:

Breaking Changes?

If yes, please describe the breakage.

Please Describe Your Changes

ndjson depends on a few outdated packages which bloat node_modules.

In this diff I replaced it with copy pasted code. json-stringify-safe is replaced with builtin JSON.stringify because csv output does not have circular dependencies. The latest version of through2 is used.

codecov-commenter commented 4 years ago

Codecov Report

Merging #170 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          141      141           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 789e0c1...4bec0cc. Read the comment docs.