refactor: drop through2

mafintosh / csv-parser

Streaming csv parser inspired by binary-csv that aims to be faster than everyone else

MIT License

1.41k stars 134 forks source link

refactor: drop through2 #178

Closed TrySound closed 3 years ago

TrySound commented 3 years ago

This PR contains:

[ ] bugfix
[ ] feature
[x] refactor
[ ] tests
[ ] documentation
[ ] metadata

Breaking Changes?

[ ] yes
[x] no

If yes, please describe the breakage.

Please Describe Your Changes

Ref https://github.com/rvagg/through2#do-you-need-this Closes https://github.com/mafintosh/csv-parser/pull/177

Builtin stream.Transform work well on node 8+.

TrySound commented 3 years ago

@contra Will this work for you?

TrySound commented 3 years ago

cc @mafintosh

yocontra commented 3 years ago

@TrySound I think this is fine, however it is recommended to use readable-stream instead of the node core stream module to avoid all sorts of issues between node versions (see the readable-stream README for more explanation).

shellscape commented 3 years ago

I don't think we need to use the userland streams package. Mostly because Node v8 is out of LTS and no longer supported. @TrySound I'd say this is good as-is if we raise the minimum Node version to an LTS version.

TrySound commented 3 years ago

Done. Bumped node support.