search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
207 stars 71 forks source link

use new Buffer APIs #1

Closed silverwind closed 8 years ago

silverwind commented 8 years ago

Replaced all instances of Buffer(num) with Buffer.allocUnsafe(num) and all other instances with Buffer.from(arg). This fixes deprecation warnings introduced in Node.js 7.0 and bumps the required Node.js version to 4.0.

reklatsmasters commented 8 years ago

bumps the required Node.js version to 4.0.

Would be better to use safe-buffer

mafintosh commented 8 years ago

What @ReklatsMasters said. Otherwise LGTM.

silverwind commented 8 years ago

Added safe-buffer and reinstated 0.10 compatibilty.

mafintosh commented 8 years ago

👍

mafintosh commented 8 years ago

1.1.1