search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
207 stars 71 forks source link

name.encode for root #13

Closed skyrising closed 6 years ago

skyrising commented 7 years ago

name.encode encodes the root domain incorrectly: '' as 00 00 and '.' as 00 00 00 instead of 00 According to RFC1035 3.1 the first 00 length byte terminates a name.

pusateri commented 6 years ago

I have a fix for this ready to push up as soon as another pull request is closed.