search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
207 stars 71 forks source link

Fix encode/decode for root name ('.') #18

Closed pusateri closed 6 years ago

pusateri commented 6 years ago

Fixes #13. Add new tests. I had to export name.encode and name.decode so they could be tested. I want to rewrite the encoder to do name compression. This isn't a problem for queries because there's just one name but for responses, the current encoder doesn't do name compression which is recommended.

silverwind commented 6 years ago

Manually merged in https://github.com/mafintosh/dns-packet/commit/2e59f463e2329570f3395f079105cb824bb7f8b9, thanks!

silverwind commented 6 years ago

@mafintosh: Maybe you'd like to add @pusateri as a collaborator to this repository.