Fix some glaring issues reported by eslint in test.js.

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets

MIT License

207 stars 71 forks source link

Fix some glaring issues reported by eslint in test.js. #19

Closed pusateri closed 6 years ago

pusateri commented 6 years ago

variables i, code used outside binding context. (block-scoped-var) / I introduced these / 'packet' is already declared in the upper scope. (no-shadow) / this one was causing me trouble / Does anyone want to contribute an .eslintrc ? I generated one based on index.js and test.js failed miserably. I will volunteer to fix others too if desired.

silverwind commented 6 years ago

Thanks!

I think I will work on integrating my config (making adjustments where necessary), if no one objects.

silverwind commented 6 years ago

ESLint added in https://github.com/mafintosh/dns-packet/commit/3632f188fa76d5ab696e6ee6a2fb1daa84b508e8.